[
https://issues.apache.org/jira/browse/BEAM-10703?focusedWorklogId=473377&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-473377
]
ASF GitHub Bot logged work on BEAM-10703:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Aug/20 17:52
Start Date: 21/Aug/20 17:52
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #12578:
URL: https://github.com/apache/beam/pull/12578#issuecomment-678413620
> > Not sure how much we want to invest in clean-up here since there are
data structures which are effective copies and the methods should take an
object that represents the computation and key instead of requiring the
explicit parameters to be exploded out. We would likely get a good savings on
memory usage since we would be passing around a single object in a lot of these
places and we would also save some CPU since we aren't creating/destroying the
objects all over the place.
> > MetricTrackingWindmillServerStub.KeyAndComputation ==
ReaderCache.CacheKey == WindmillStateCache.ComputationKey
> > There are some other types which are sub/super types of the one above.
>
> Sounds good to deduplicate. Would it make sense to have a separate PR for
clean-up?
Yes, a separate PR sounds best.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 473377)
Time Spent: 2h 20m (was: 2h 10m)
> Add support for auto-sharded GroupIntoBatches in Dataflow runner
> ----------------------------------------------------------------
>
> Key: BEAM-10703
> URL: https://issues.apache.org/jira/browse/BEAM-10703
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Siyuan Chen
> Assignee: Siyuan Chen
> Priority: P2
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> The proposal of improving GroupIntoBatches transform is in BEAM-10475
> This tracks the support in Cloud Dataflow Runner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
