[
https://issues.apache.org/jira/browse/BEAM-10703?focusedWorklogId=473379&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-473379
]
ASF GitHub Bot logged work on BEAM-10703:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Aug/20 17:56
Start Date: 21/Aug/20 17:56
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #12578:
URL: https://github.com/apache/beam/pull/12578#discussion_r474844750
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java
##########
@@ -2205,20 +2238,18 @@ public void completeWork(ByteString key, long
workToken) {
throw new NullPointerException(
String.format(
"No active state for key %s, expected token %s",
- TextFormat.escapeBytes(key), workToken));
+ shardedKey.toString(), workToken));
}
if (completedWork.getWorkItem().getWorkToken() != workToken) {
throw new IllegalStateException(
String.format(
"Token mismatch for key %s: %s and %s",
- TextFormat.escapeBytes(key),
- completedWork.getWorkItem().getWorkToken(),
- workToken));
+ shardedKey.toString(),
completedWork.getWorkItem().getWorkToken(), workToken));
Review comment:
```suggestion
shardedKey, completedWork.getWorkItem().getWorkToken(),
workToken));
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 473379)
Time Spent: 2h 40m (was: 2.5h)
> Add support for auto-sharded GroupIntoBatches in Dataflow runner
> ----------------------------------------------------------------
>
> Key: BEAM-10703
> URL: https://issues.apache.org/jira/browse/BEAM-10703
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Siyuan Chen
> Assignee: Siyuan Chen
> Priority: P2
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> The proposal of improving GroupIntoBatches transform is in BEAM-10475
> This tracks the support in Cloud Dataflow Runner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
