[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=487988&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-487988
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Sep/20 06:48
Start Date: 22/Sep/20 06:48
Worklog Time Spent: 10m
Work Description: codecov[bot] commented on pull request #12881:
URL: https://github.com/apache/beam/pull/12881#issuecomment-696540479
# [Codecov](https://codecov.io/gh/apache/beam/pull/12881?src=pr&el=h1) Report
> Merging
[#12881](https://codecov.io/gh/apache/beam/pull/12881?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/beam/commit/067cba8229694e7fb9693313f51ca686746b620a?el=desc)
will **decrease** coverage by `0.01%`.
> The diff coverage is `89.16%`.
[](https://codecov.io/gh/apache/beam/pull/12881?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12881 +/- ##
==========================================
- Coverage 82.34% 82.32% -0.02%
==========================================
Files 452 454 +2
Lines 54016 54109 +93
==========================================
+ Hits 44481 44547 +66
- Misses 9535 9562 +27
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/12881?src=pr&el=tree) | Coverage
Δ | |
|---|---|---|
|
[sdks/python/apache\_beam/coders/coder\_impl.py](https://codecov.io/gh/apache/beam/pull/12881/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVyX2ltcGwucHk=)
| `95.12% <0.00%> (-0.14%)` | :arrow_down: |
|
[sdks/python/apache\_beam/utils/timestamp.py](https://codecov.io/gh/apache/beam/pull/12881/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvdGltZXN0YW1wLnB5)
| `95.43% <ø> (ø)` | |
|
[sdks/python/apache\_beam/utils/windowed\_value.py](https://codecov.io/gh/apache/beam/pull/12881/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvd2luZG93ZWRfdmFsdWUucHk=)
| `92.54% <ø> (ø)` | |
|
[...s/python/apache\_beam/runners/worker/log\_handler.py](https://codecov.io/gh/apache/beam/pull/12881/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvbG9nX2hhbmRsZXIucHk=)
| `87.71% <83.33%> (+0.10%)` | :arrow_up: |
|
[...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/12881/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==)
| `88.29% <84.84%> (-1.05%)` | :arrow_down: |
|
[...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/12881/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvZGF0YV9wbGFuZS5weQ==)
| `89.52% <85.71%> (-0.39%)` | :arrow_down: |
|
[...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12881/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==)
| `94.07% <89.47%> (-0.51%)` | :arrow_down: |
|
[...ks/python/apache\_beam/runners/worker/statecache.py](https://codecov.io/gh/apache/beam/pull/12881/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc3RhdGVjYWNoZS5weQ==)
| `96.18% <93.75%> (-0.54%)` | :arrow_down: |
|
[sdks/python/apache\_beam/runners/worker/logger.py](https://codecov.io/gh/apache/beam/pull/12881/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvbG9nZ2VyLnB5)
| `93.75% <100.00%> (-0.28%)` | :arrow_down: |
|
[...ks/python/apache\_beam/runners/worker/opcounters.py](https://codecov.io/gh/apache/beam/pull/12881/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvb3Bjb3VudGVycy5weQ==)
| `84.50% <100.00%> (+0.10%)` | :arrow_up: |
| ... and [15
more](https://codecov.io/gh/apache/beam/pull/12881/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/12881?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/12881?src=pr&el=footer). Last
update
[067cba8...f252b9c](https://codecov.io/gh/apache/beam/pull/12881?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 487988)
Time Spent: 94.5h (was: 94h 20m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Priority: P3
> Time Spent: 94.5h
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
