[
https://issues.apache.org/jira/browse/BEAM-6233?focusedWorklogId=189492&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189492
]
ASF GitHub Bot logged work on BEAM-6233:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jan/19 14:04
Start Date: 24/Jan/19 14:04
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #7330: [BEAM-6233]:
Add initial user timer support in Dataflow for batch pipelines
URL: https://github.com/apache/beam/pull/7330#discussion_r250616612
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/control/ProcessRemoteBundleOperation.java
##########
@@ -84,10 +170,21 @@ public void start() throws Exception {
@Override
public void process(Object inputElement) throws Exception {
- LOG.debug(String.format("Sending value: %s", inputElement));
+ LOG.debug(String.format("Sending element: %s", inputElement));
+ String mainInputPCollectionId =
executableStage.getInputPCollection().getId();
+ FnDataReceiver<WindowedValue<?>> mainInputReceiver =
+ remoteBundle.getInputReceivers().get(mainInputPCollectionId);
+
+ // TODO(BEAM-6274): Is this always true? Do we always send the input
element to the main input receiver?
Review comment:
This will not be true once timers are implented, and possibly not for SDF or
other stage shapes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 189492)
Time Spent: 2.5h (was: 2h 20m)
> Make bundle execution with ExecutableStage support timer/states
> ---------------------------------------------------------------
>
> Key: BEAM-6233
> URL: https://issues.apache.org/jira/browse/BEAM-6233
> Project: Beam
> Issue Type: Task
> Components: runner-dataflow
> Reporter: Boyuan Zhang
> Assignee: Sam Rohde
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
