[
https://issues.apache.org/jira/browse/BEAM-6233?focusedWorklogId=189587&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189587
]
ASF GitHub Bot logged work on BEAM-6233:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jan/19 17:50
Start Date: 24/Jan/19 17:50
Worklog Time Spent: 10m
Work Description: rohdesamuel commented on pull request #7330:
[BEAM-6233]: Add initial user timer support in Dataflow for batch pipelines
URL: https://github.com/apache/beam/pull/7330#discussion_r250712409
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/control/ProcessRemoteBundleOperation.java
##########
@@ -100,6 +197,75 @@ public void finish() throws Exception {
} catch (Exception e) {
throw new RuntimeException("Failed to finish remote bundle", e);
}
+
+ // TODO(BEAM-6274): do we have to put this in the "start" method as well?
+ try (RemoteBundle bundle =
Review comment:
Like we talked yesterday, timers are allowed to A) fire other timers, and B)
fire themselves. To implement this, we send the timer to the SDK Harness, wait
for any elements, then check if any additional timers were fired. This is
enough for now, but it'll be good to check the performance once more people are
using it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 189587)
Time Spent: 2h 40m (was: 2.5h)
> Make bundle execution with ExecutableStage support timer/states
> ---------------------------------------------------------------
>
> Key: BEAM-6233
> URL: https://issues.apache.org/jira/browse/BEAM-6233
> Project: Beam
> Issue Type: Task
> Components: runner-dataflow
> Reporter: Boyuan Zhang
> Assignee: Sam Rohde
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
