[
https://issues.apache.org/jira/browse/BEAM-10950?focusedWorklogId=489862&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-489862
]
ASF GitHub Bot logged work on BEAM-10950:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Sep/20 21:55
Start Date: 23/Sep/20 21:55
Worklog Time Spent: 10m
Work Description: pabloem commented on a change in pull request #12782:
URL: https://github.com/apache/beam/pull/12782#discussion_r493917934
##########
File path: sdks/python/apache_beam/io/gcp/bigquery_test.py
##########
@@ -168,7 +168,8 @@ def test_invalid_json_neg_inf(self):
@unittest.skipIf(HttpError is None, 'GCP dependencies are not installed')
class TestBigQuerySource(unittest.TestCase):
def test_display_data_item_on_validate_true(self):
- source = beam.io.BigQuerySource('dataset.table', validate=True)
+ source = beam.io.BigQuerySource(
Review comment:
yes, most tests have variants for the new and the old source running
alongside each other.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 489862)
Time Spent: 1h 20m (was: 1h 10m)
> Override Dataflow-native implementation of BQSource with a Beam source
> ----------------------------------------------------------------------
>
> Key: BEAM-10950
> URL: https://issues.apache.org/jira/browse/BEAM-10950
> Project: Beam
> Issue Type: Improvement
> Components: io-py-gcp
> Reporter: Pablo Estrada
> Assignee: Pablo Estrada
> Priority: P2
> Fix For: 2.25.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
