[
https://issues.apache.org/jira/browse/BEAM-10950?focusedWorklogId=489861&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-489861
]
ASF GitHub Bot logged work on BEAM-10950:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Sep/20 21:55
Start Date: 23/Sep/20 21:55
Worklog Time Spent: 10m
Work Description: pabloem commented on a change in pull request #12782:
URL: https://github.com/apache/beam/pull/12782#discussion_r493917759
##########
File path: sdks/python/apache_beam/io/gcp/bigquery_tools_test.py
##########
@@ -451,7 +451,9 @@ def test_read_from_table(self):
client.jobs.GetQueryResults.return_value =
bigquery.GetQueryResultsResponse(
jobComplete=True, rows=table_rows, schema=schema)
actual_rows = []
- with beam.io.BigQuerySource('dataset.table').reader(client) as reader:
+ with beam.io.BigQuerySource(
Review comment:
I've filed the JIRA (BEAM-10951) - the tests in this class are using
`BigQuerySource`-specific functions. The new sources do not implement the
`reader` function, which we use mainly to support BQSource in direct runner.
The tests in this class should be deleted if BQSource goes away.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 489861)
Time Spent: 1h 10m (was: 1h)
> Override Dataflow-native implementation of BQSource with a Beam source
> ----------------------------------------------------------------------
>
> Key: BEAM-10950
> URL: https://issues.apache.org/jira/browse/BEAM-10950
> Project: Beam
> Issue Type: Improvement
> Components: io-py-gcp
> Reporter: Pablo Estrada
> Assignee: Pablo Estrada
> Priority: P2
> Fix For: 2.25.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
