[
https://issues.apache.org/jira/browse/BEAM-8660?focusedWorklogId=489867&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-489867
]
ASF GitHub Bot logged work on BEAM-8660:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Sep/20 22:01
Start Date: 23/Sep/20 22:01
Worklog Time Spent: 10m
Work Description: sambvfx commented on a change in pull request #12905:
URL: https://github.com/apache/beam/pull/12905#discussion_r493920269
##########
File path: sdks/python/apache_beam/runners/portability/portable_runner.py
##########
@@ -105,9 +106,11 @@ def submit(self, proto_pipeline):
Submit and run the pipeline defined by `proto_pipeline`.
"""
prepare_response = self.prepare(proto_pipeline)
+ artifact_endpoint = (self.artifact_endpoint
Review comment:
Ah thanks, sorry forgot to run the lint
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 489867)
Time Spent: 3.5h (was: 3h 20m)
> Override returned artifact staging endpoint
> -------------------------------------------
>
> Key: BEAM-8660
> URL: https://issues.apache.org/jira/browse/BEAM-8660
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Reporter: Kyle Weaver
> Assignee: Sam Bourne
> Priority: P2
> Labels: portability-flink
> Fix For: 2.18.0
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> When running Beam Python pipelines on Flink/Spark/etc, we connect the SDK to
> the job server using the job_endpoint option. The job server then returns the
> address of the artifact staging endpoint to the SDK.
> This is problematic when running the job server in network environments where
> the job server is not aware of its external hostname, for example Kubernetes.
> In this case, the job server will return something like localhost:8098, which
> might not be correct. While we do have a --job-host option, this is used both
> internally and externally, and the internal and external host names may not
> be the same.
> One solution would be to configure two separate host names in the job server.
> However I do not prefer this option because of the complexity it adds.
> The more straightforward solution is to add an option to Python that
> overrides the artifact staging endpoint returned by the server.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
