[
https://issues.apache.org/jira/browse/BEAM-8660?focusedWorklogId=489871&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-489871
]
ASF GitHub Bot logged work on BEAM-8660:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Sep/20 22:03
Start Date: 23/Sep/20 22:03
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #12905:
URL: https://github.com/apache/beam/pull/12905#issuecomment-696946990
# [Codecov](https://codecov.io/gh/apache/beam/pull/12905?src=pr&el=h1) Report
> Merging
[#12905](https://codecov.io/gh/apache/beam/pull/12905?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/beam/commit/967d7288cd5069f21617c98a9156dd4076bb9fb9?el=desc)
will **decrease** coverage by `0.10%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/beam/pull/12905?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12905 +/- ##
==========================================
- Coverage 82.45% 82.35% -0.11%
==========================================
Files 454 454
Lines 54607 54121 -486
==========================================
- Hits 45028 44573 -455
+ Misses 9579 9548 -31
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/12905?src=pr&el=tree) | Coverage
Δ | |
|---|---|---|
|
[...apache\_beam/runners/portability/portable\_runner.py](https://codecov.io/gh/apache/beam/pull/12905/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9wb3J0YWJsZV9ydW5uZXIucHk=)
| `77.53% <100.00%> (+0.16%)` | :arrow_up: |
|
[sdks/python/apache\_beam/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12905/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vX19pbml0X18ucHk=)
| `80.00% <0.00%> (-5.72%)` | :arrow_down: |
|
[conftest.py](https://codecov.io/gh/apache/beam/pull/12905/diff?src=pr&el=tree#diff-Y29uZnRlc3QucHk=)
| `77.77% <0.00%> (-5.56%)` | :arrow_down: |
|
[...pache\_beam/runners/interactive/interactive\_beam.py](https://codecov.io/gh/apache/beam/pull/12905/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9iZWFtLnB5)
| `76.02% <0.00%> (-2.99%)` | :arrow_down: |
|
[sdks/python/apache\_beam/dataframe/io.py](https://codecov.io/gh/apache/beam/pull/12905/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2lvLnB5)
| `89.62% <0.00%> (-2.47%)` | :arrow_down: |
|
[.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12905/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5)
| `96.49% <0.00%> (-1.76%)` | :arrow_down: |
|
[...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12905/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==)
| `88.28% <0.00%> (-1.15%)` | :arrow_down: |
|
[sdks/python/apache\_beam/transforms/ptransform.py](https://codecov.io/gh/apache/beam/pull/12905/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wdHJhbnNmb3JtLnB5)
| `91.04% <0.00%> (-0.97%)` | :arrow_down: |
|
[...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12905/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==)
| `98.31% <0.00%> (-0.76%)` | :arrow_down: |
|
[sdks/python/apache\_beam/typehints/schemas.py](https://codecov.io/gh/apache/beam/pull/12905/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3NjaGVtYXMucHk=)
| `93.20% <0.00%> (-0.52%)` | :arrow_down: |
| ... and [19
more](https://codecov.io/gh/apache/beam/pull/12905/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/12905?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/12905?src=pr&el=footer). Last
update
[379ba0e...300d38d](https://codecov.io/gh/apache/beam/pull/12905?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 489871)
Time Spent: 3h 50m (was: 3h 40m)
> Override returned artifact staging endpoint
> -------------------------------------------
>
> Key: BEAM-8660
> URL: https://issues.apache.org/jira/browse/BEAM-8660
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Reporter: Kyle Weaver
> Assignee: Sam Bourne
> Priority: P2
> Labels: portability-flink
> Fix For: 2.18.0
>
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> When running Beam Python pipelines on Flink/Spark/etc, we connect the SDK to
> the job server using the job_endpoint option. The job server then returns the
> address of the artifact staging endpoint to the SDK.
> This is problematic when running the job server in network environments where
> the job server is not aware of its external hostname, for example Kubernetes.
> In this case, the job server will return something like localhost:8098, which
> might not be correct. While we do have a --job-host option, this is used both
> internally and externally, and the internal and external host names may not
> be the same.
> One solution would be to configure two separate host names in the job server.
> However I do not prefer this option because of the complexity it adds.
> The more straightforward solution is to add an option to Python that
> overrides the artifact staging endpoint returned by the server.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
