[
https://issues.apache.org/jira/browse/BEAM-10435?focusedWorklogId=493212&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-493212
]
ASF GitHub Bot logged work on BEAM-10435:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Sep/20 23:25
Start Date: 30/Sep/20 23:25
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #12981:
URL: https://github.com/apache/beam/pull/12981#discussion_r497854932
##########
File path: runners/portability/java/build.gradle
##########
@@ -108,95 +120,113 @@ startLocalJobService.finalizedBy stopLocalJobService
/**
* Runs Java ValidatesRunner tests against the Universal Local Runner (ULR)
aka local_job_service_main
- * with subprocess SDK harness environments.
+ * with the specified environment type.
*/
-task ulrValidatesRunnerTests(type: Test) {
- dependsOn ":sdks:java:container:docker"
-
- if (!project.hasProperty("localJobServicePortFile")) {
- dependsOn startLocalJobService
+def createUlrValidatesRunnerTask = { name, environmentType ->
+ Task vrTask = tasks.create(name: name, type: Test, group: "Verification") {
+ description "PortableRunner Java docker ValidatesRunner suite"
+ classpath = configurations.validatesRunner
+ systemProperty "beamTestPipelineOptions", JsonOutput.toJson([
+ "--runner=TestUniversalRunner",
+ "--experiments=beam_fn_api",
+ "--defaultEnvironmentType=${environmentType}",
+ "--localJobServicePortFile=${localJobServicePortFile}"
+ ])
+ testClassesDirs =
files(project(":sdks:java:core").sourceSets.test.output.classesDirs)
+ useJUnit {
+ includeCategories 'org.apache.beam.sdk.testing.ValidatesRunner'
+ excludeCategories 'org.apache.beam.sdk.testing.UsesGaugeMetrics'
+ excludeCategories 'org.apache.beam.sdk.testing.UsesOnWindowExpiration'
+ excludeCategories 'org.apache.beam.sdk.testing.UsesBundleFinalizer'
Review comment:
Do we need a TODO for any of these exclusions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 493212)
Time Spent: 2h 50m (was: 2h 40m)
> ValidatesRunner tests for Java SDK on (Python-based) Universal Local Runner
> ---------------------------------------------------------------------------
>
> Key: BEAM-10435
> URL: https://issues.apache.org/jira/browse/BEAM-10435
> Project: Beam
> Issue Type: Test
> Components: sdk-java-core, sdk-java-harness
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: P2
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
