[
https://issues.apache.org/jira/browse/BEAM-10435?focusedWorklogId=493220&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-493220
]
ASF GitHub Bot logged work on BEAM-10435:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Sep/20 23:31
Start Date: 30/Sep/20 23:31
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#12981:
URL: https://github.com/apache/beam/pull/12981#discussion_r497856286
##########
File path: runners/portability/java/build.gradle
##########
@@ -82,8 +87,15 @@ void execBackgroundInVirtualenv(String... args) {
proc.waitFor();
}
-task startLocalJobService {
+task installBeamPythonInVirtualenv {
dependsOn setupVirtualenv
+ doLast {
+ execInVirtualenv "pip", "install", "-e", "."
Review comment:
So you mean more of an approach like this?
```
dependsOn ':sdks:python:sdist'
doLast {
def distTarBall = "${pythonRootDir}/build/apache-beam.tar.gz"
execInVirtualenv "pip", "install", "--retries", "10", distTarBall
}
}
}
```
I am not familiar with the install variants. For ValidatesRunner we should
not need any cloud-specific things. I do not know what `[test]` changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 493220)
Time Spent: 4h (was: 3h 50m)
> ValidatesRunner tests for Java SDK on (Python-based) Universal Local Runner
> ---------------------------------------------------------------------------
>
> Key: BEAM-10435
> URL: https://issues.apache.org/jira/browse/BEAM-10435
> Project: Beam
> Issue Type: Test
> Components: sdk-java-core, sdk-java-harness
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: P2
> Time Spent: 4h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
