[
https://issues.apache.org/jira/browse/BEAM-10967?focusedWorklogId=499637&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-499637
]
ASF GitHub Bot logged work on BEAM-10967:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Oct/20 21:01
Start Date: 12/Oct/20 21:01
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#13025:
URL: https://github.com/apache/beam/pull/13025#discussion_r503529979
##########
File path: runners/google-cloud-dataflow-java/build.gradle
##########
@@ -227,6 +227,34 @@ task validatesRunner {
dependsOn validatesRunnerLegacyWorkerTest
}
+task validatesRunnerV2Test(type: Test) {
+ group = "Verification"
+ dependsOn buildAndPushDockerContainer
+
+ systemProperty "beamTestPipelineOptions", JsonOutput.toJson([
+ "--runner=TestDataflowRunner",
+ "--project=${dataflowProject}",
+ "--region=${dataflowRegion}",
+ "--tempRoot=${dataflowValidatesTempRoot}",
+ "--workerHarnessContainerImage=${dockerImageContainer}:${dockerTag}",
+ "--experiments=beam_fn_api,use_unified_worker",
+ ])
+
+ // Increase test parallelism up to the number of Gradle workers. By default
this is equal
+ // to the number of CPU cores, but can be increased by setting
--max-workers=N.
+ maxParallelForks Integer.MAX_VALUE
+ classpath = configurations.validatesRunner
+ testClassesDirs =
files(project(":sdks:java:core").sourceSets.test.output.classesDirs) +
+ files(project(project.path).sourceSets.test.output.classesDirs)
+ useJUnit {
+ includeCategories 'org.apache.beam.sdk.testing.ValidatesRunner'
+ excludeCategories 'org.apache.beam.sdk.testing.RunnerV2Incompatible'
+ commonExcludeCategories.each {
Review comment:
I will make the stronger statement that I prefer to not use a
"commonExcludeCategories" as it is not self documenting and not causal. Only if
there is a shared _cause_ for not supporting something should you share the
list of exclusions. Otherwise each exclusion overlaps only by coincidence and
should not be shared but listed separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 499637)
Time Spent: 2h 10m (was: 2h)
> adding validate runner for Dataflow runner v2 to Java SDK
> ---------------------------------------------------------
>
> Key: BEAM-10967
> URL: https://issues.apache.org/jira/browse/BEAM-10967
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow, sdk-java-harness
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: P2
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> adding validate runner for Dataflow runner v2 to Java SDK (Java harness)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
