[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=501701&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-501701
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Oct/20 22:38
Start Date: 16/Oct/20 22:38
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #13060:
URL: https://github.com/apache/beam/pull/13060#discussion_r506748112
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
##########
@@ -539,6 +548,7 @@ def merge_results(last_result):
else:
data_input = deferred_inputs
input_timers = fired_timers
+ # FIXME: this seems unused, and produces an attr-defined error
bundle_manager._registered = True
Review comment:
Yes, this should not be needed anymore.
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/worker_handlers.py
##########
@@ -1062,34 +1104,41 @@ def close(self):
class ControlFuture(object):
- def __init__(self, instruction_id, response=None):
+ def __init__(self,
+ instruction_id, # type: str
+ response=None # type:
Optional[beam_fn_api_pb2.InstructionResponse]
+ ):
+ # type: (...) -> None
self.instruction_id = instruction_id
- if response:
- self._response = response
- else:
- self._response = None
+ self._response = response
+ if response is None:
self._condition = threading.Condition()
- self._exception = None
+ self._exception = None # type: Optional[Exception]
def is_done(self):
+ # type: () -> bool
return self._response is not None
def set(self, response):
+ # type: (beam_fn_api_pb2.InstructionResponse) -> None
with self._condition:
self._response = response
self._condition.notify_all()
def get(self, timeout=None):
+ # type: (Optional[float]) -> beam_fn_api_pb2.InstructionResponse
if not self._response and not self._exception:
with self._condition:
if not self._response and not self._exception:
self._condition.wait(timeout)
if self._exception:
raise self._exception
else:
+ assert self._response is not None
Review comment:
Correct, either an exception will be thrown, a timeout will be thrown,
or the response is non-None.
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/execution.py
##########
@@ -227,12 +251,24 @@ def __iter__(self):
"""
return itertools.chain(*self.partition(1))
+ # these should never be accessed, but they allow this class to meet the
Review comment:
How about making them raise errors rather than be no-ops?
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py
##########
@@ -307,6 +308,9 @@ def executable_stage_transform(
for side in side_inputs
},
main_input=main_input_id)
+ # at this point we should have resolved an environment, as the key of
+ # components.environments cannot be None.
+ assert self.environment is not None
Review comment:
Yes, that looks safe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 501701)
Time Spent: 112.5h (was: 112h 20m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Priority: P3
> Time Spent: 112.5h
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
