[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=501716&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-501716
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Oct/20 01:11
Start Date: 17/Oct/20 01:11
Worklog Time Spent: 10m
Work Description: chadrik commented on a change in pull request #13060:
URL: https://github.com/apache/beam/pull/13060#discussion_r506776533
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/execution.py
##########
@@ -227,12 +251,24 @@ def __iter__(self):
"""
return itertools.chain(*self.partition(1))
+ # these should never be accessed, but they allow this class to meet the
Review comment:
I prefer the current solution because it's reasonable and safe to call
`clear()` and `reset()` on this class and have it do nothing: there's simply
nothing to clear or reset. It seems wrong to meet the protocol definition,
but then error if the methods are called: that's not really meeting the
protocol.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 501716)
Time Spent: 112h 40m (was: 112.5h)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Priority: P3
> Time Spent: 112h 40m
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
