[
https://issues.apache.org/jira/browse/BEAM-5959?focusedWorklogId=191148&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-191148
]
ASF GitHub Bot logged work on BEAM-5959:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jan/19 17:38
Start Date: 28/Jan/19 17:38
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #7629: [BEAM-5959] DO
NOT MERGE: KMS support for FileBasedSink, GCS
URL: https://github.com/apache/beam/pull/7629#discussion_r251498991
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/AvroIO.java
##########
@@ -431,7 +431,8 @@
.setNumShards(0)
.setCodec(TypedWrite.DEFAULT_SERIALIZABLE_CODEC)
.setMetadata(ImmutableMap.of())
- .setWindowedWrites(false);
+ .setWindowedWrites(false)
+ .setKmsKey(null);
Review comment:
We must not modify core file based IOs (e.g. AvroIO, TextIO, etc) with
`setKmsKey`, this is a concern of the FileSystem not of the formats, so this
should be part of the Options of the FileSystem, e.g. GcsOptions. Please take a
look at how is done for
[S3Options](https://github.com/apache/beam/blob/3b9eab91d1dd2101ede8c514fedd2dc35f3b94d9/sdks/java/io/amazon-web-services/src/main/java/org/apache/beam/sdk/io/aws/options/S3Options.java#L72).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 191148)
Time Spent: 17.5h (was: 17h 20m)
> Add Cloud KMS support to GCS creates and copies
> -----------------------------------------------
>
> Key: BEAM-5959
> URL: https://issues.apache.org/jira/browse/BEAM-5959
> Project: Beam
> Issue Type: Bug
> Components: io-java-gcp, sdk-py-core
> Reporter: Udi Meiri
> Assignee: Udi Meiri
> Priority: Major
> Time Spent: 17.5h
> Remaining Estimate: 0h
>
> Beam SDK currently uses the CopyTo GCS API call, which doesn't support
> copying objects that Customer Managed Encryption Keys (CMEK).
> CMEKs are managed in Cloud KMS.
> Items (for Java and Python SDKs):
> - Update clients to versions that support KMS keys.
> - Change copyTo API calls to use rewriteTo (Python - directly, Java -
> possibly convert copyTo API call to use client library)
> - Add unit tests.
> - Add basic tests (DirectRunner and GCS buckets with CMEK).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
