[
https://issues.apache.org/jira/browse/BEAM-5959?focusedWorklogId=191147&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-191147
]
ASF GitHub Bot logged work on BEAM-5959:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jan/19 17:38
Start Date: 28/Jan/19 17:38
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #7629: [BEAM-5959] DO
NOT MERGE: KMS support for FileBasedSink, GCS
URL: https://github.com/apache/beam/pull/7629#discussion_r251515041
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/io/fs/MoveOptions.java
##########
@@ -17,16 +17,61 @@
*/
package org.apache.beam.sdk.io.fs;
+import com.google.auto.value.AutoValue;
+import javax.annotation.Nullable;
+import org.apache.beam.sdk.annotations.Experimental;
+import org.apache.beam.sdk.annotations.Experimental.Kind;
import org.apache.beam.sdk.io.FileSystems;
/**
* An object that configures {@link FileSystems#copy}, {@link
FileSystems#rename}, and {@link
* FileSystems#delete}.
*/
-public interface MoveOptions {
+public abstract class MoveOptions {
+
+ /**
+ * If false, operations will abort on errors arising from missing files.
Otherwise, operations
+ * will ignore such errors.
+ */
+ public abstract boolean getIgnoreMissingFiles();
+
+ /**
+ * Specifies the Key Management System key name to use to encrypt new files
with.
+ *
+ * <p>Only relevant to operations that create new files and filesystems that
support KMS features.
+ */
+ @Experimental(Kind.FILESYSTEM)
+ @Nullable
+ public abstract String getDestKmsKey();
Review comment:
This should not be done here but better in the FileSystem options. Notice
also that you may need to set up a different SourceKmsKey so this should be
considered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 191147)
Time Spent: 17.5h (was: 17h 20m)
> Add Cloud KMS support to GCS creates and copies
> -----------------------------------------------
>
> Key: BEAM-5959
> URL: https://issues.apache.org/jira/browse/BEAM-5959
> Project: Beam
> Issue Type: Bug
> Components: io-java-gcp, sdk-py-core
> Reporter: Udi Meiri
> Assignee: Udi Meiri
> Priority: Major
> Time Spent: 17.5h
> Remaining Estimate: 0h
>
> Beam SDK currently uses the CopyTo GCS API call, which doesn't support
> copying objects that Customer Managed Encryption Keys (CMEK).
> CMEKs are managed in Cloud KMS.
> Items (for Java and Python SDKs):
> - Update clients to versions that support KMS keys.
> - Change copyTo API calls to use rewriteTo (Python - directly, Java -
> possibly convert copyTo API call to use client library)
> - Add unit tests.
> - Add basic tests (DirectRunner and GCS buckets with CMEK).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
