[
https://issues.apache.org/jira/browse/BEAM-5939?focusedWorklogId=504960&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-504960
]
ASF GitHub Bot logged work on BEAM-5939:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Oct/20 23:49
Start Date: 26/Oct/20 23:49
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #13142:
URL: https://github.com/apache/beam/pull/13142#issuecomment-716887038
Thanks for your help, @tszerszen .
1. DATAFLOW_SDK_TARBALL_FILE != WORKFLOW_TARBALL_FILE.
DATAFLOW_SDK_TARBALL_FILE is the name used to stage sources of apache beam
sdk to staging location.
WORKFLOW_TARBALL_FILE is a tarball file representing sources of the pipeline
in case the pipeline is wrapped into a python package.
2. It would be easier to review if you separated yapf changes in a separate
commit. Are changes in groupby_test.py relevant?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 504960)
Time Spent: 3h 50m (was: 3h 40m)
> Deduplicate constants
> ---------------------
>
> Key: BEAM-5939
> URL: https://issues.apache.org/jira/browse/BEAM-5939
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Ahmet Altay
> Assignee: Tomasz Szerszen
> Priority: P3
> Labels: starer
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> apache_beam/runners/dataflow/internal/names.py
> apache_beam/runners/portability/stager.py
> has same constants defined in both files.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
