[
https://issues.apache.org/jira/browse/BEAM-5939?focusedWorklogId=506355&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-506355
]
ASF GitHub Bot logged work on BEAM-5939:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Oct/20 19:16
Start Date: 29/Oct/20 19:16
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #13142:
URL: https://github.com/apache/beam/pull/13142#discussion_r514505595
##########
File path: sdks/python/apache_beam/runners/dataflow/internal/names.py
##########
@@ -27,7 +27,13 @@
# Standard file names used for staging files.
from builtins import object
-DATAFLOW_SDK_TARBALL_FILE = 'dataflow_python_sdk.tar'
+# pylint: disable=unused-import
+from apache_beam.runners.internal.names import DATAFLOW_SDK_TARBALL_FILE
+from apache_beam.runners.internal.names import PICKLED_MAIN_SESSION_FILE
Review comment:
Please add the comment `# Referenced by Dataflow legacy worker. `
before `from apache_beam.runners.internal.names import
PICKLED_MAIN_SESSION_FILE`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 506355)
Time Spent: 5h (was: 4h 50m)
> Deduplicate constants
> ---------------------
>
> Key: BEAM-5939
> URL: https://issues.apache.org/jira/browse/BEAM-5939
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Ahmet Altay
> Assignee: Tomasz Szerszen
> Priority: P3
> Labels: starer
> Time Spent: 5h
> Remaining Estimate: 0h
>
> apache_beam/runners/dataflow/internal/names.py
> apache_beam/runners/portability/stager.py
> has same constants defined in both files.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
