[
https://issues.apache.org/jira/browse/BEAM-10940?focusedWorklogId=505347&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-505347
]
ASF GitHub Bot logged work on BEAM-10940:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Oct/20 17:55
Start Date: 27/Oct/20 17:55
Worklog Time Spent: 10m
Work Description: boyuanzz commented on a change in pull request #13105:
URL: https://github.com/apache/beam/pull/13105#discussion_r512908978
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java
##########
@@ -484,6 +530,148 @@ void setTimer(Timer<?> timerElement,
TimerInternals.TimerData timerData) {
}
}
+ /**
+ * A {@link TimerInternalsFactory} for Flink operator to create a {@link
+ * StateAndTimerBundleCheckpointHandler} to handle {@link
+ * org.apache.beam.model.fnexecution.v1.BeamFnApi.DelayedBundleApplication}.
+ */
+ class SdfFlinkTimerInternalsFactory implements TimerInternalsFactory<InputT>
{
+ @Override
+ public TimerInternals timerInternalsForKey(InputT key) {
+ try {
+ ByteBuffer encodedKey =
+ (ByteBuffer)
keySelector.getKey(WindowedValue.valueInGlobalWindow(key));
+ return new SdfFlinkTimerInternals(encodedKey);
+ } catch (Exception e) {
+ throw new RuntimeException("Couldn't get a timer internals", e);
+ }
+ }
+ }
+
+ /**
+ * A {@link TimerInternals} for rescheduling {@link
+ * org.apache.beam.model.fnexecution.v1.BeamFnApi.DelayedBundleApplication}.
+ */
+ class SdfFlinkTimerInternals implements TimerInternals {
+ private final ByteBuffer key;
+
+ SdfFlinkTimerInternals(ByteBuffer key) {
+ this.key = key;
+ }
+
+ @Override
+ public void setTimer(
+ StateNamespace namespace,
+ String timerId,
+ String timerFamilyId,
+ Instant target,
+ Instant outputTimestamp,
+ TimeDomain timeDomain) {
+ setTimer(
+ TimerData.of(timerId, timerFamilyId, namespace, target,
outputTimestamp, timeDomain));
+ }
+
+ @Override
+ public void setTimer(TimerData timerData) {
+ try {
+ try (Locker locker = Locker.locked(stateBackendLock)) {
+ getKeyedStateBackend().setCurrentKey(key);
+ timerInternals.setTimer(timerData);
+ minEventTimeTimerTimestampInCurrentBundle =
+ Math.min(
+ minEventTimeTimerTimestampInCurrentBundle,
+
adjustTimestampForFlink(timerData.getOutputTimestamp().getMillis()));
+ }
+ } catch (Exception e) {
+ throw new RuntimeException("Couldn't set timer", e);
+ }
+ }
+
+ @Override
+ public void deleteTimer(StateNamespace namespace, String timerId,
TimeDomain timeDomain) {
+ throw new UnsupportedOperationException(
+ "It is not expected to use SdfFlinkTimerInternals to delete a
timer");
+ }
+
+ @Override
+ public void deleteTimer(StateNamespace namespace, String timerId, String
timerFamilyId) {
+ throw new UnsupportedOperationException(
+ "It is not expected to use SdfFlinkTimerInternals to delete a
timer");
+ }
+
+ @Override
+ public void deleteTimer(TimerData timerKey) {
+ throw new UnsupportedOperationException(
+ "It is not expected to use SdfFlinkTimerInternals to delete a
timer");
+ }
+
+ @Override
+ public Instant currentProcessingTime() {
+ return timerInternals.currentProcessingTime();
+ }
+
+ @Override
+ public @Nullable Instant currentSynchronizedProcessingTime() {
+ return timerInternals.currentSynchronizedProcessingTime();
+ }
+
+ @Override
+ public Instant currentInputWatermarkTime() {
+ return timerInternals.currentInputWatermarkTime();
+ }
+
+ @Override
+ public @Nullable Instant currentOutputWatermarkTime() {
+ return timerInternals.currentOutputWatermarkTime();
+ }
+ }
+
+ /**
+ * A {@link StateInternalsFactory} for Flink operator to create a {@link
+ * StateAndTimerBundleCheckpointHandler} to handle {@link
+ * org.apache.beam.model.fnexecution.v1.BeamFnApi.DelayedBundleApplication}.
+ */
+ class SdfFlinkStateInternalsFactory implements StateInternalsFactory<InputT>
{
+ @Override
+ public StateInternals stateInternalsForKey(InputT key) {
+ try {
+ ByteBuffer encodedKey =
+ (ByteBuffer)
keySelector.getKey(WindowedValue.valueInGlobalWindow(key));
+ return new SdfFlinkStateInternals(encodedKey);
+ } catch (Exception e) {
+ throw new RuntimeException("Couldn't get a state internals", e);
+ }
+ }
+ }
+
+ /** A {@link StateInternals} for keeping {@link DelayedBundleApplication}s
as states. */
+ class SdfFlinkStateInternals implements StateInternals {
Review comment:
I want to keep `SdfFlinkInternals` and `SdfTimerInternals` as inner
class so that they can access to `getKeyedStateBackend()`, `timerInternals` and
`stateInternals` from outer class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 505347)
Time Spent: 7h 10m (was: 7h)
> Portable Flink runner should handle DelayedBundleApplication from
> ProcessBundleResponse.
> ----------------------------------------------------------------------------------------
>
> Key: BEAM-10940
> URL: https://issues.apache.org/jira/browse/BEAM-10940
> Project: Beam
> Issue Type: New Feature
> Components: runner-flink
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: P2
> Time Spent: 7h 10m
> Remaining Estimate: 0h
>
> SDF can produce residuals by self-checkpoint, which will be returned to
> runner by ProcessBundleResponse.DelayedBundleApplication. The portable runner
> should be able to handle the DelayedBundleApplication and reschedule it based
> on the timestamp.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
