[
https://issues.apache.org/jira/browse/BEAM-10940?focusedWorklogId=505356&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-505356
]
ASF GitHub Bot logged work on BEAM-10940:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Oct/20 18:19
Start Date: 27/Oct/20 18:19
Worklog Time Spent: 10m
Work Description: boyuanzz commented on a change in pull request #13105:
URL: https://github.com/apache/beam/pull/13105#discussion_r512926708
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -1315,7 +1316,7 @@ void processPendingProcessingTimeTimers() {
keyedStateBackend.setCurrentKey(internalTimer.getKey());
TimerData timer = internalTimer.getNamespace();
checkInvokeStartBundle();
- fireTimer(timer);
+ fireTimerInternal((ByteBuffer) internalTimer.getKey(), timer);
Review comment:
I think so. The only difference is that `fireTimerInternal` will grab
the lock and set the key for state backend, which is helpful when the state is
needed. Another potential bug around here is that Flink operator will clean up
global state first then fire the timer, which may lead to data loss if firing
timer is for retrieving the state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 505356)
Time Spent: 7.5h (was: 7h 20m)
> Portable Flink runner should handle DelayedBundleApplication from
> ProcessBundleResponse.
> ----------------------------------------------------------------------------------------
>
> Key: BEAM-10940
> URL: https://issues.apache.org/jira/browse/BEAM-10940
> Project: Beam
> Issue Type: New Feature
> Components: runner-flink
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: P2
> Time Spent: 7.5h
> Remaining Estimate: 0h
>
> SDF can produce residuals by self-checkpoint, which will be returned to
> runner by ProcessBundleResponse.DelayedBundleApplication. The portable runner
> should be able to handle the DelayedBundleApplication and reschedule it based
> on the timestamp.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
