[ 
https://issues.apache.org/jira/browse/BEAM-3736?focusedWorklogId=507853&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-507853
 ]

ASF GitHub Bot logged work on BEAM-3736:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Nov/20 23:36
            Start Date: 04/Nov/20 23:36
    Worklog Time Spent: 10m 
      Work Description: tvalentyn commented on pull request #13048:
URL: https://github.com/apache/beam/pull/13048#issuecomment-722032127


   Looks like this test is not marked as a ValidatesRunner test in Beam. Adding 
the annotation in https://github.com/apache/beam/pull/13265.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 507853)
    Time Spent: 10.5h  (was: 10h 20m)

> Add SetUp() and TearDown() for CombineFns
> -----------------------------------------
>
>                 Key: BEAM-3736
>                 URL: https://issues.apache.org/jira/browse/BEAM-3736
>             Project: Beam
>          Issue Type: Improvement
>          Components: beam-model, sdk-py-core
>            Reporter: Chuan Yu Foo
>            Assignee: Kamil Wasilewski
>            Priority: P3
>          Time Spent: 10.5h
>  Remaining Estimate: 0h
>
> I have a CombineFn that has a large amount of state that needs to be loaded 
> once before it can add_input or merge_combiners (for example, the CombineFn 
> might load up a large lookup table used for combining). 
> Right now, to initialise this state, for each of the methods, I check if the 
> state has already been initialised, and if not, I initialise it. It would be 
> nice if CombineFn provided a SetUp() method that is called once to initialise 
> this state (and a corresponding TearDown() method to clean up this state if 
> necessary).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to