[
https://issues.apache.org/jira/browse/BEAM-3736?focusedWorklogId=507866&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-507866
]
ASF GitHub Bot logged work on BEAM-3736:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Nov/20 00:00
Start Date: 05/Nov/20 00:00
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #13048:
URL: https://github.com/apache/beam/pull/13048#issuecomment-722039186
> I don't have an idea how to fix this at the moment though. I think we can
disable the visitor for now to keep the tests working.
Ok. We can do that and mention in changelogs and in the setup/teardown
docstring that this feature is not supported on Dataflow without runner V2.
I am also taking a look for what it takes to add support for this in
Dataflow runner v1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 507866)
Time Spent: 11h (was: 10h 50m)
> Add SetUp() and TearDown() for CombineFns
> -----------------------------------------
>
> Key: BEAM-3736
> URL: https://issues.apache.org/jira/browse/BEAM-3736
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, sdk-py-core
> Reporter: Chuan Yu Foo
> Assignee: Kamil Wasilewski
> Priority: P3
> Time Spent: 11h
> Remaining Estimate: 0h
>
> I have a CombineFn that has a large amount of state that needs to be loaded
> once before it can add_input or merge_combiners (for example, the CombineFn
> might load up a large lookup table used for combining).
> Right now, to initialise this state, for each of the methods, I check if the
> state has already been initialised, and if not, I initialise it. It would be
> nice if CombineFn provided a SetUp() method that is called once to initialise
> this state (and a corresponding TearDown() method to clean up this state if
> necessary).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
