[
https://issues.apache.org/jira/browse/BEAM-9547?focusedWorklogId=508550&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-508550
]
ASF GitHub Bot logged work on BEAM-9547:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Nov/20 17:55
Start Date: 06/Nov/20 17:55
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #13264:
URL: https://github.com/apache/beam/pull/13264#discussion_r518567211
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -1069,6 +1069,23 @@ def dropna(self, axis, **kwargs):
preserves_partition_by=partitionings.Singleton(),
requires_partition_by=requires_partition_by))
+
+ # TODO(BEAM-XXXX): support @<local> in eval and query. Currently fails in
+ # proxy generation
Review comment:
Go ahead and create the jira. Can we give a better message if @ is in
the expression?
##########
File path: sdks/python/apache_beam/dataframe/frame_base.py
##########
@@ -318,8 +318,8 @@ def wrapper(self, *args, **kwargs):
def maybe_inplace(func):
@functools.wraps(func)
- def wrapper(self, inplace=False, **kwargs):
- result = func(self, **kwargs)
+ def wrapper(self, *args, inplace=False, **kwargs):
Review comment:
This is dangerous, as it won't catch if inplace was passed as a
non-keyword argument.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 508550)
Time Spent: 33h 40m (was: 33.5h)
> Implement all pandas operations (or raise WontImplementError)
> -------------------------------------------------------------
>
> Key: BEAM-9547
> URL: https://issues.apache.org/jira/browse/BEAM-9547
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Brian Hulette
> Assignee: Robert Bradshaw
> Priority: P2
> Time Spent: 33h 40m
> Remaining Estimate: 0h
>
> We should have an implementation for every DataFrame, Series, and GroupBy
> method. Everything that's not actually implemented should get a default
> implementation that raises WontImplementError
> See https://github.com/apache/beam/pull/10757#discussion_r389132292
> Progress at the individual operation level is tracked in a
> [spreadsheet|https://docs.google.com/spreadsheets/d/1hHAaJ0n0k2tw465ORs5tfdy4Lg0DnGWIQ53cLjAhel0/edit],
> consider requesting edit access if you'd like to help out.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
