[
https://issues.apache.org/jira/browse/BEAM-9547?focusedWorklogId=508577&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-508577
]
ASF GitHub Bot logged work on BEAM-9547:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Nov/20 19:53
Start Date: 06/Nov/20 19:53
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#13264:
URL: https://github.com/apache/beam/pull/13264#discussion_r518970400
##########
File path: sdks/python/apache_beam/dataframe/frame_base.py
##########
@@ -318,8 +318,8 @@ def wrapper(self, *args, **kwargs):
def maybe_inplace(func):
@functools.wraps(func)
- def wrapper(self, inplace=False, **kwargs):
- result = func(self, **kwargs)
+ def wrapper(self, *args, inplace=False, **kwargs):
Review comment:
That could happen only with methods where the first kwarg is `inplace`
right? I wouldn't think there's many of those but I suppose there could be.
So what's the right thing to do here? We could use inspect to find `inplace`
in the args/kwargs of `func` and handle it correctly. Or more simply just never
use this in methods where we need to pass through args.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 508577)
Time Spent: 33h 50m (was: 33h 40m)
> Implement all pandas operations (or raise WontImplementError)
> -------------------------------------------------------------
>
> Key: BEAM-9547
> URL: https://issues.apache.org/jira/browse/BEAM-9547
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Brian Hulette
> Assignee: Robert Bradshaw
> Priority: P2
> Time Spent: 33h 50m
> Remaining Estimate: 0h
>
> We should have an implementation for every DataFrame, Series, and GroupBy
> method. Everything that's not actually implemented should get a default
> implementation that raises WontImplementError
> See https://github.com/apache/beam/pull/10757#discussion_r389132292
> Progress at the individual operation level is tracked in a
> [spreadsheet|https://docs.google.com/spreadsheets/d/1hHAaJ0n0k2tw465ORs5tfdy4Lg0DnGWIQ53cLjAhel0/edit],
> consider requesting edit access if you'd like to help out.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
