[
https://issues.apache.org/jira/browse/BEAM-11337?focusedWorklogId=517127&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-517127
]
ASF GitHub Bot logged work on BEAM-11337:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Nov/20 17:20
Start Date: 26/Nov/20 17:20
Worklog Time Spent: 10m
Work Description: ccciudatu commented on pull request #13415:
URL: https://github.com/apache/beam/pull/13415#issuecomment-734413926
@chrlarsen I see what you mean, I noticed the check in
`ThriftIO.ReadFiles.withProtocol()`.
However, I'm not sure it's the responsibility of this class to keep track of
the limitations of each protocol, especially as one can provide their own
custom protocol for which we have no way to assess the capabilities.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 517127)
Time Spent: 40m (was: 0.5h)
> Make the ThriftCoder class visible from outside its package
> -----------------------------------------------------------
>
> Key: BEAM-11337
> URL: https://issues.apache.org/jira/browse/BEAM-11337
> Project: Beam
> Issue Type: Improvement
> Components: io-java-utilities
> Affects Versions: 2.25.0
> Reporter: Costi Ciudatu
> Priority: P2
> Labels: thrift
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The {{ThriftCoder}} class is currently only visible in the {{thrift}}
> package, to be used by {{ThriftIO}}, which can only handle files.
> However, this class can also be useful when consuming/producing thrift data
> from/to other sources/sinks, such as Kafka topics and alike.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
