[
https://issues.apache.org/jira/browse/BEAM-11337?focusedWorklogId=517140&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-517140
]
ASF GitHub Bot logged work on BEAM-11337:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Nov/20 18:02
Start Date: 26/Nov/20 18:02
Worklog Time Spent: 10m
Work Description: ccciudatu edited a comment on pull request #13415:
URL: https://github.com/apache/beam/pull/13415#issuecomment-734413926
@chrlarsen I see what you mean, I noticed the check in
`ThriftIO.ReadFiles.withProtocol()`.
However, I'm not sure it's the responsibility of the `ThriftCoder` class to
keep track of the limitations of each protocol, especially as one can provide
their own custom protocol for which we have no way to assess the capabilities.
It would be nice to ensure that one cannot shoot themselves in the foot and
we can probably move/copy the above check in the public static method and only
let the non-public constructor accept anything (for the write path). But I'm
not sure it's worth it...
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 517140)
Time Spent: 1h (was: 50m)
> Make the ThriftCoder class visible from outside its package
> -----------------------------------------------------------
>
> Key: BEAM-11337
> URL: https://issues.apache.org/jira/browse/BEAM-11337
> Project: Beam
> Issue Type: Improvement
> Components: io-java-utilities
> Affects Versions: 2.25.0
> Reporter: Costi Ciudatu
> Priority: P2
> Labels: thrift
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The {{ThriftCoder}} class is currently only visible in the {{thrift}}
> package, to be used by {{ThriftIO}}, which can only handle files.
> However, this class can also be useful when consuming/producing thrift data
> from/to other sources/sinks, such as Kafka topics and alike.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
