[
https://issues.apache.org/jira/browse/BEAM-10986?focusedWorklogId=518673&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-518673
]
ASF GitHub Bot logged work on BEAM-10986:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Dec/20 22:04
Start Date: 01/Dec/20 22:04
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#13453:
URL: https://github.com/apache/beam/pull/13453#discussion_r533737969
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1041,6 +1041,10 @@ class BeamModulePlugin implements Plugin<Project> {
}
testCompile.extendsFrom shadowTest
}
+
+ project.tasks.named('build').configure {
Review comment:
nit: it would be good to have a comment justifying this, something like:
```suggestion
// Ensure build task depends on shadowJar (required for shadow
plugin >=4.0.4)
project.tasks.named('build').configure {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 518673)
Time Spent: 5.5h (was: 5h 20m)
> :build task doesn't build shaded jar with shadow >5.0.0
> -------------------------------------------------------
>
> Key: BEAM-10986
> URL: https://issues.apache.org/jira/browse/BEAM-10986
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: P0
> Fix For: 2.25.0
>
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> Not 100% sure but I believe this will prevent us from releasing shaded jars.
> See
> [https://lists.apache.org/thread.html/r12c785c2b01017329204ad816740e80b70c19c5f2bb1ea01535a987d%40%3Cdev.beam.apache.org%3E]
> for details.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
