[
https://issues.apache.org/jira/browse/BEAM-5658?focusedWorklogId=193005&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-193005
]
ASF GitHub Bot logged work on BEAM-5658:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jan/19 20:04
Start Date: 31/Jan/19 20:04
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #7684:
[BEAM-5658] Re-enable findbugs on Dataflow worker
URL: https://github.com/apache/beam/pull/7684#discussion_r252796906
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/AvroByteReader.java
##########
@@ -58,17 +56,17 @@
final Coder<T> coder;
private final Schema schema = Schema.create(Schema.Type.BYTES);
- public AvroByteReader(
+ AvroByteReader(
String filename,
long startPosition,
long endPosition,
Coder<T> coder,
PipelineOptions options) {
- this.filename = checkNotNull(filename, "filename");
Review comment:
It is enabled for most modules, and I intend to follow up and enable it
here, too. So the question is what to do in the meantime before we have good
static analysis in place.
We enforce good programming practice by code review well enough (but
obviously not perfectly!) that I am not terribly worried about what happens in
the interim. For example, this check almost certainly just moves an NPE closer
to the site of the error. OTOH I could leave checks in place until we flip the
switch. Incidentally this is an incorrect check, as it should be checkArgument.
I'll fix this one and also restore other checks for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 193005)
Time Spent: 2h (was: 1h 50m)
> Enable FindBugs in dataflow java worker code
> --------------------------------------------
>
> Key: BEAM-5658
> URL: https://issues.apache.org/jira/browse/BEAM-5658
> Project: Beam
> Issue Type: Test
> Components: runner-dataflow
> Reporter: Boyuan Zhang
> Assignee: Kenneth Knowles
> Priority: Critical
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Currently we disabled FindBugs task in worker code. We should enable if after
> fixing all related warnings and errors.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
