[
https://issues.apache.org/jira/browse/BEAM-5658?focusedWorklogId=193014&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-193014
]
ASF GitHub Bot logged work on BEAM-5658:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jan/19 20:04
Start Date: 31/Jan/19 20:04
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #7684:
[BEAM-5658] Re-enable findbugs on Dataflow worker
URL: https://github.com/apache/beam/pull/7684#discussion_r252816767
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/DataflowMetricsContainer.java
##########
@@ -29,7 +30,11 @@
* An implementation of {@link MetricsContainer} that reads the current
execution state (tracked in
* a field) to determine the current step. This allows the {@link
MetricsEnvironment} to only be
* updated once on entry to the entire stage, rather than in between every
step.
+ *
+ * <p><b>Not actually serializable</b>. {@link MetricsContainer} is
Serializable only due to its
Review comment:
There is no base class, as it is an interface. And I wrote this comment here
with excessive confidence. I'm not so sure now. I am not totally convinced
there is any reason for `MetricsContainer` to extend `Serializable`. Instead
I've filed https://issues.apache.org/jira/browse/BEAM-6573 and linked it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 193014)
Time Spent: 3h (was: 2h 50m)
> Enable FindBugs in dataflow java worker code
> --------------------------------------------
>
> Key: BEAM-5658
> URL: https://issues.apache.org/jira/browse/BEAM-5658
> Project: Beam
> Issue Type: Test
> Components: runner-dataflow
> Reporter: Boyuan Zhang
> Assignee: Kenneth Knowles
> Priority: Critical
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Currently we disabled FindBugs task in worker code. We should enable if after
> fixing all related warnings and errors.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
