[
https://issues.apache.org/jira/browse/BEAM-11432?focusedWorklogId=523328&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-523328
]
ASF GitHub Bot logged work on BEAM-11432:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Dec/20 22:07
Start Date: 11/Dec/20 22:07
Worklog Time Spent: 10m
Work Description: emilymye commented on a change in pull request #13517:
URL: https://github.com/apache/beam/pull/13517#discussion_r541346292
##########
File path: sdks/go/container/build.gradle
##########
@@ -47,12 +47,14 @@ golang {
}
}
+def defaultTag = project.rootProject.hasProperty(["docker-tag"]) ?
[project.rootProject["docker-tag"], 'latest'] : ['latest']
Review comment:
ah, I see. Would it work to just ignore docker-tag for dockerTagPush and
just use one flag like docker-tags or docker-tag-list? Mostly I don't quite
like the idea of splitting the tag flag - if docker-tags isn't given, we can
just construct a list from docker-tag, or use `["latest"]`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 523328)
Time Spent: 1.5h (was: 1h 20m)
> put latest tag when publishing SDK head containers to gcr
> ---------------------------------------------------------
>
> Key: BEAM-11432
> URL: https://issues.apache.org/jira/browse/BEAM-11432
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution, testing
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: P2
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> put latest tag when publishing SDK head containers to gcr
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
