[
https://issues.apache.org/jira/browse/BEAM-11432?focusedWorklogId=524767&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-524767
]
ASF GitHub Bot logged work on BEAM-11432:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Dec/20 23:16
Start Date: 15/Dec/20 23:16
Worklog Time Spent: 10m
Work Description: ihji commented on a change in pull request #13517:
URL: https://github.com/apache/beam/pull/13517#discussion_r543756966
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1704,6 +1704,20 @@ class BeamModulePlugin implements Plugin<Project> {
return "${configuration.root}/${configuration.name}:${configuration.tag}"
}
+ project.ext.containerImageTags = {
+ String[] tags
+ if (project.rootProject.hasProperty(["docker-tag-list"])) {
+ tags = project.rootProject["docker-tag-list"].split(',')
+ } else {
+ tags = [
+ project.rootProject.hasProperty(["docker-tag"]) ?
+ project.rootProject["docker-tag"] : project.sdk_version,
Review comment:
We need to add some default anyway in case that `docker-tag` property is
not given. Since we already use `project.sdk_version` as a default for
`docker` command, I choose the same default for `dockerTag`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 524767)
Time Spent: 2h 10m (was: 2h)
> put latest tag when publishing SDK head containers to gcr
> ---------------------------------------------------------
>
> Key: BEAM-11432
> URL: https://issues.apache.org/jira/browse/BEAM-11432
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution, testing
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: P2
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> put latest tag when publishing SDK head containers to gcr
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
