[ 
https://issues.apache.org/jira/browse/BEAM-11458?focusedWorklogId=524727&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-524727
 ]

ASF GitHub Bot logged work on BEAM-11458:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Dec/20 21:48
            Start Date: 15/Dec/20 21:48
    Worklog Time Spent: 10m 
      Work Description: Zhangyx39 commented on a change in pull request #13550:
URL: https://github.com/apache/beam/pull/13550#discussion_r543710544



##########
File path: 
runners/samza/src/main/java/org/apache/beam/runners/samza/SamzaExecutionContext.java
##########
@@ -178,7 +179,11 @@ public SamzaExecutionContext create(
 
       final MetricsRegistryMap metricsRegistry =
           (MetricsRegistryMap) containerContext.getContainerMetricsRegistry();
-      SamzaExecutionContext.this.setMetricsContainer(new 
SamzaMetricsContainer(metricsRegistry));
+      SamzaMetricsContainer samzaMetricsContainer =

Review comment:
       There are multiple metrics related changes. The ones that are related to 
global metrics container doesn't need to push to open source. For now, we can 
exclude all metrics related commits from this PR. We can do that in a separate 
PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 524727)
    Time Spent: 1.5h  (was: 1h 20m)

> Upgrade SamzRunner to Samza 1.5
> -------------------------------
>
>                 Key: BEAM-11458
>                 URL: https://issues.apache.org/jira/browse/BEAM-11458
>             Project: Beam
>          Issue Type: Task
>          Components: runner-samza
>            Reporter: Ke Wu
>            Assignee: Ke Wu
>            Priority: P2
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to