[
https://issues.apache.org/jira/browse/BEAM-11458?focusedWorklogId=524741&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-524741
]
ASF GitHub Bot logged work on BEAM-11458:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Dec/20 22:23
Start Date: 15/Dec/20 22:23
Worklog Time Spent: 10m
Work Description: Zhangyx39 commented on a change in pull request #13550:
URL: https://github.com/apache/beam/pull/13550#discussion_r543730502
##########
File path:
runners/samza/src/main/java/org/apache/beam/runners/samza/adapter/UnboundedSourceSystem.java
##########
@@ -268,6 +269,7 @@ public void register(SystemStreamPartition ssp, String
offset) {
private final FnWithMetricsWrapper metricsWrapper;
private volatile boolean running;
+ private volatile boolean maxWatermarkReached = false;
Review comment:
This is needed to finish a nexmark test in streaming mode. As
@xinyuiscool suggested, we can remove this flag and just use the running flag.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 524741)
Time Spent: 1h 50m (was: 1h 40m)
> Upgrade SamzRunner to Samza 1.5
> -------------------------------
>
> Key: BEAM-11458
> URL: https://issues.apache.org/jira/browse/BEAM-11458
> Project: Beam
> Issue Type: Task
> Components: runner-samza
> Reporter: Ke Wu
> Assignee: Ke Wu
> Priority: P2
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
