[
https://issues.apache.org/jira/browse/BEAM-11481?focusedWorklogId=525536&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-525536
]
ASF GitHub Bot logged work on BEAM-11481:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Dec/20 12:54
Start Date: 17/Dec/20 12:54
Worklog Time Spent: 10m
Work Description: je-ik commented on a change in pull request #13571:
URL: https://github.com/apache/beam/pull/13571#discussion_r545067861
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -641,8 +641,10 @@ protected final void setBundleFinishedCallback(Runnable
callback) {
@Override
public final void processElement(StreamRecord<WindowedValue<InputT>>
streamRecord) {
checkInvokeStartBundle();
+ long oldHold = keyCoder != null ? keyedStateInternals.minWatermarkHoldMs()
: -1L;
doFnRunner.processElement(streamRecord.getValue());
checkInvokeFinishBundleByCount();
+ emitWatermarkIfHoldChanged(oldHold);
Review comment:
This is very cheap call and actually tests exactly if hold was set
(actually reset).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 525536)
Time Spent: 1.5h (was: 1h 20m)
> FlinkRunner might not advance output watermark on change of watermark hold
> --------------------------------------------------------------------------
>
> Key: BEAM-11481
> URL: https://issues.apache.org/jira/browse/BEAM-11481
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Affects Versions: 2.25.0, 2.26.0
> Reporter: Jan Lukavský
> Assignee: Jan Lukavský
> Priority: P0
> Fix For: 2.27.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Output watermark of DoFnOperator is advanced only when new input watermark is
> received. The output watermark might advance even on timer or processed
> element due to updated watermark hold. This especially holds true in
> splittable DoFn.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
