[
https://issues.apache.org/jira/browse/BEAM-11481?focusedWorklogId=525538&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-525538
]
ASF GitHub Bot logged work on BEAM-11481:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Dec/20 12:58
Start Date: 17/Dec/20 12:58
Worklog Time Spent: 10m
Work Description: je-ik commented on a change in pull request #13571:
URL: https://github.com/apache/beam/pull/13571#discussion_r545070247
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -739,9 +741,12 @@ public final void processWatermark1(Watermark mark) throws
Exception {
}
currentInputWatermark = mark.getTimestamp();
+ processInputWatermark(true);
+ }
+ private void processInputWatermark(boolean advanceInputWatermark) throws
Exception {
Review comment:
I think that is what we must do. We could call `processWatermark` from
`processElement`, but the call does stuff not necessary to do in
`processElement`. That's why I simply wrapped what is needed to be done in
`processInputWatermark` (maybe we could find a better name to make it clearer).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 525538)
Time Spent: 1h 40m (was: 1.5h)
> FlinkRunner might not advance output watermark on change of watermark hold
> --------------------------------------------------------------------------
>
> Key: BEAM-11481
> URL: https://issues.apache.org/jira/browse/BEAM-11481
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Affects Versions: 2.25.0, 2.26.0
> Reporter: Jan Lukavský
> Assignee: Jan Lukavský
> Priority: P0
> Fix For: 2.27.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Output watermark of DoFnOperator is advanced only when new input watermark is
> received. The output watermark might advance even on timer or processed
> element due to updated watermark hold. This especially holds true in
> splittable DoFn.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
