[
https://issues.apache.org/jira/browse/BEAM-11530?focusedWorklogId=529611&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-529611
]
ASF GitHub Bot logged work on BEAM-11530:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Dec/20 19:37
Start Date: 30/Dec/20 19:37
Worklog Time Spent: 10m
Work Description: krakowski commented on pull request #13622:
URL: https://github.com/apache/beam/pull/13622#issuecomment-752734701
I rebased on top of `master` an reran `spotlessApply` so everything should
be working now. After the checks have passed, this is ready to be merged from
my side :+1:
Thanks for reviewing this and giving advice! :slightly_smiling_face:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 529611)
Time Spent: 3h 40m (was: 3.5h)
> Annotated setter parameters handled wrong in schema creation
> ------------------------------------------------------------
>
> Key: BEAM-11530
> URL: https://issues.apache.org/jira/browse/BEAM-11530
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Affects Versions: 2.26.0
> Environment: Linux & OpenJDK 15
> Reporter: Filip Krakowski
> Priority: P0
> Labels: annotation, fieldtype, parameter, schema
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> I'm facing an exception telling me that my JavaBean contained a setter for a
> field that had a mismatching nullable attribute, although both getter and
> setter (parameters) are annotated with @Nullable.
>
> The code responsible for determining if a setter's parameter is nullable
> looks wrong to me, since it -does check if the type (class) itself is
> annotated with @Nullable instead of checking the actual parameter's
> annotations- only considers type annotations instead of looking at parameter
> annotations, too. Java distinguishes between parameter annotations and type
> annotations. Therefore annotations declared without
> _java.lang.annotation.ElementType#TYPE_USE_ can't be accessed through
> _Executable#getAnnotatedParameterTypes()_.
>
> [FieldValueTypeInformation|https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/FieldValueTypeInformation.java#L234-L236]
> {code:java}
> boolean nullable =
> Arrays.stream(method.getParameters()[0].getAnnotatedType().getAnnotations())
> .anyMatch(annotation -> isNullableAnnotation(annotation));{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
