[
https://issues.apache.org/jira/browse/BEAM-11530?focusedWorklogId=529241&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-529241
]
ASF GitHub Bot logged work on BEAM-11530:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Dec/20 19:21
Start Date: 29/Dec/20 19:21
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #13622:
URL: https://github.com/apache/beam/pull/13622#issuecomment-752212662
> or should I revert to using org.apache.avro.reflect.Nullable and remove
the custom annotation?
Let's just use the avro Nullable annotation
> Found the answer at https://stackoverflow.com/a/37587590/5896429
Nice! Thank you. Could you add a comment linking to that with a brief
explanation?
It looks like CI is failing because of the spotless format check - you can
autoformat with `./gradlew spotlessApply`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 529241)
Time Spent: 2h 40m (was: 2.5h)
> Annotated setter parameters handled wrong in schema creation
> ------------------------------------------------------------
>
> Key: BEAM-11530
> URL: https://issues.apache.org/jira/browse/BEAM-11530
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Affects Versions: 2.26.0
> Environment: Linux & OpenJDK 15
> Reporter: Filip Krakowski
> Priority: P0
> Labels: annotation, fieldtype, parameter, schema
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> I'm facing an exception telling me that my JavaBean contained a setter for a
> field that had a mismatching nullable attribute, although both getter and
> setter (parameters) are annotated with @Nullable.
>
> The code responsible for determining if a setter's parameter is nullable
> looks wrong to me, since it does check if the type (class) itself is
> annotated with @Nullable instead of checking the actual parameter's
> annotations.
>
> [FieldValueTypeInformation|https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/FieldValueTypeInformation.java#L234-L236]
> {code:java}
> boolean nullable =
> Arrays.stream(method.getParameters()[0].getAnnotatedType().getAnnotations())
> .anyMatch(annotation -> isNullableAnnotation(annotation));{code}
>
> In my understanding this should look like this.
> {code:java}
> boolean nullable =
> Arrays.stream(method.getParameters()[0].getAnnotations())
> .anyMatch(FieldValueTypeInformation::isNullableAnnotation);{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
