[jira] [Work logged] (BEAM-11272) Combiner Label Constructor Arg Not Passed Through To pTransform

Wed, 06 Jan 2021 08:47:06 -0800 


     [ 
https://issues.apache.org/jira/browse/BEAM-11272?focusedWorklogId=531966&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-531966
 ]

ASF GitHub Bot logged work on BEAM-11272:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Jan/21 16:46
            Start Date: 06/Jan/21 16:46
    Worklog Time Spent: 10m 
      Work Description: codecov[bot] edited a comment on pull request #13355:
URL: https://github.com/apache/beam/pull/13355#issuecomment-755405694


   # [Codecov](https://codecov.io/gh/apache/beam/pull/13355?src=pr&el=h1) Report
   > Merging 
[#13355](https://codecov.io/gh/apache/beam/pull/13355?src=pr&el=desc) (22c2d29) 
into 
[master](https://codecov.io/gh/apache/beam/commit/b2ad4ddbf16fe6680a4876dfa3f093d1db5be8ec?el=desc)
 (b2ad4dd) will **decrease** coverage by `0.01%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/beam/pull/13355/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/13355?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13355      +/-   ##
   ==========================================
   - Coverage   82.75%   82.73%   -0.02%     
   ==========================================
     Files         466      466              
     Lines       57518    57519       +1     
   ==========================================
   - Hits        47599    47591       -8     
   - Misses       9919     9928       +9     
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/beam/pull/13355?src=pr&el=tree) | Coverage 
Δ | |
   |---|---|---|
   | 
[sdks/python/apache\_beam/transforms/combiners.py](https://codecov.io/gh/apache/beam/pull/13355/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lcnMucHk=)
 | `91.47% <100.00%> (+0.01%)` | :arrow_up: |
   | 
[.../python/apache\_beam/testing/test\_stream\_service.py](https://codecov.io/gh/apache/beam/pull/13355/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy90ZXN0X3N0cmVhbV9zZXJ2aWNlLnB5)
 | `88.63% <0.00%> (-4.55%)` | :arrow_down: |
   | 
[...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/13355/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==)
 | `91.91% <0.00%> (-2.21%)` | :arrow_down: |
   | 
[...che\_beam/runners/interactive/interactive\_runner.py](https://codecov.io/gh/apache/beam/pull/13355/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9ydW5uZXIucHk=)
 | `90.90% <0.00%> (-1.82%)` | :arrow_down: |
   | 
[...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/13355/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==)
 | `93.57% <0.00%> (-0.26%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/beam/pull/13355?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/beam/pull/13355?src=pr&el=footer). Last 
update 
[b2ad4dd...22c2d29](https://codecov.io/gh/apache/beam/pull/13355?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 531966)
    Time Spent: 2h 10m  (was: 2h)

> Combiner Label Constructor Arg Not Passed Through To pTransform
> ---------------------------------------------------------------
>
>                 Key: BEAM-11272
>                 URL: https://issues.apache.org/jira/browse/BEAM-11272
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Robbie Gruener
>            Priority: P3
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> The combiners ToSet, ToDict, and ToList have a label argument in their 
> constructor:
> [https://github.com/apache/beam/blob/master/sdks/python/apache_beam/transforms/combiners.py#L877]
>  
> However the label passed through to the parent class is not actually used 
> (there is a mismatch in the super constructor) 
> https://github.com/apache/beam/blob/7ac82a875462f2c2570a1157b782ebadddebbe70/sdks/python/apache_beam/transforms/combiners.py#L68



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to