[
https://issues.apache.org/jira/browse/BEAM-11593?focusedWorklogId=537367&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-537367
]
ASF GitHub Bot logged work on BEAM-11593:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jan/21 12:41
Start Date: 18/Jan/21 12:41
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on a change in pull request
#13715:
URL: https://github.com/apache/beam/pull/13715#discussion_r559537346
##########
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/SparkRunnerRegistrar.java
##########
@@ -41,8 +39,7 @@ private SparkRunnerRegistrar() {}
public static class Runner implements PipelineRunnerRegistrar {
@Override
public Iterable<Class<? extends PipelineRunner<?>>> getPipelineRunners() {
- return ImmutableList.of(
- SparkRunner.class, TestSparkRunner.class,
SparkStructuredStreamingRunner.class);
+ return ImmutableList.of(SparkRunner.class, TestSparkRunner.class);
Review comment:
Is it a breaking change? If yes then it would make sense to add a note
about that into `CHANGES`
##########
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/structuredstreaming/SparkStructuredStreamingRunnerRegistrar.java
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.runners.spark.structuredstreaming;
+
+import com.google.auto.service.AutoService;
+import org.apache.beam.sdk.PipelineRunner;
+import org.apache.beam.sdk.options.PipelineOptions;
+import org.apache.beam.sdk.options.PipelineOptionsRegistrar;
+import org.apache.beam.sdk.runners.PipelineRunnerRegistrar;
+import
org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.ImmutableList;
+
+/**
+ * Contains the {@link PipelineRunnerRegistrar} and {@link
PipelineOptionsRegistrar} for the {@link
+ * SparkRunner}.
Review comment:
nit: `SparkStructuredStreamingRunner` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 537367)
Time Spent: 3h 40m (was: 3.5h)
> Move SparkStructuredStreamingRunnerRegistrar to its own package
> ---------------------------------------------------------------
>
> Key: BEAM-11593
> URL: https://issues.apache.org/jira/browse/BEAM-11593
> Project: Beam
> Issue Type: Improvement
> Components: runner-spark
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: P2
> Labels: structured-streaming
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> When the Spark Structured Runner was merged I could not figure out a way to
> register the runner on its own. with this the runner will be fully isolated
> into its own package.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
