[
https://issues.apache.org/jira/browse/BEAM-11593?focusedWorklogId=537393&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-537393
]
ASF GitHub Bot logged work on BEAM-11593:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jan/21 13:44
Start Date: 18/Jan/21 13:44
Worklog Time Spent: 10m
Work Description: iemejia commented on a change in pull request #13715:
URL: https://github.com/apache/beam/pull/13715#discussion_r559575687
##########
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/SparkRunnerRegistrar.java
##########
@@ -41,8 +39,7 @@ private SparkRunnerRegistrar() {}
public static class Runner implements PipelineRunnerRegistrar {
@Override
public Iterable<Class<? extends PipelineRunner<?>>> getPipelineRunners() {
- return ImmutableList.of(
- SparkRunner.class, TestSparkRunner.class,
SparkStructuredStreamingRunner.class);
+ return ImmutableList.of(SparkRunner.class, TestSparkRunner.class);
Review comment:
No it is not a breaking change because the
SparkStructuredStreamingRunnerProvider takes care of registering the runner
class independently (and this is validated by the tests (Nexmark concretely)
who rely on this shortened translation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 537393)
Time Spent: 4h (was: 3h 50m)
> Move SparkStructuredStreamingRunnerRegistrar to its own package
> ---------------------------------------------------------------
>
> Key: BEAM-11593
> URL: https://issues.apache.org/jira/browse/BEAM-11593
> Project: Beam
> Issue Type: Improvement
> Components: runner-spark
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: P2
> Labels: structured-streaming
> Time Spent: 4h
> Remaining Estimate: 0h
>
> When the Spark Structured Runner was merged I could not figure out a way to
> register the runner on its own. with this the runner will be fully isolated
> into its own package.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
