[
https://issues.apache.org/jira/browse/BEAM-6595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kenneth Knowles updated BEAM-6595:
----------------------------------
Description:
Currently, the build_release_candidate.sh does many things beyond the build
- Edits files in place to update the version from SNAPSHOT to non-SNAPSHOT
- Makes a local commit
- Pushes commits to release branch
- Reverts on failure, pushes those to release branch
Instead, the release manager should determine what gets pushed. It is less
fragile of a process and avoids cruft getting pushed and churning the branch.
The only thing the plugin is really good for is flipping SNAPSHOT away and
back. And it isn't even that great because that's Java only and other languages
are at non-SNAPSHOT anyhow.
was:
Currently, the cut_release_branch.sh does many things:
- Edits files in place to update the version
- Makes a local commit
- Pushing the local commit to master
- Creates a new branch
- Edits files in place to update the version
- Pushes the release branch
I think all of this except the push to master are OK. It is possible that we
have something - website, examples, new places where the version is hardcoded,
etc, that get broken in this process. Moving from x-SNAPSHOT to (x+1)-SNAPSHOT
is easy to do in a pull request and safe. The release branch creation does not
need to be synchronized with this.
> build_release_candidate.sh should not push to github
> ----------------------------------------------------
>
> Key: BEAM-6595
> URL: https://issues.apache.org/jira/browse/BEAM-6595
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
>
> Currently, the build_release_candidate.sh does many things beyond the build
> - Edits files in place to update the version from SNAPSHOT to non-SNAPSHOT
> - Makes a local commit
> - Pushes commits to release branch
> - Reverts on failure, pushes those to release branch
> Instead, the release manager should determine what gets pushed. It is less
> fragile of a process and avoids cruft getting pushed and churning the branch.
> The only thing the plugin is really good for is flipping SNAPSHOT away and
> back. And it isn't even that great because that's Java only and other
> languages are at non-SNAPSHOT anyhow.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
