[
https://issues.apache.org/jira/browse/BEAM-6595?focusedWorklogId=194732&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-194732
]
ASF GitHub Bot logged work on BEAM-6595:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Feb/19 18:36
Start Date: 05/Feb/19 18:36
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #7735:
[BEAM-6595] Do not push to release branch when cutting release candidate
URL: https://github.com/apache/beam/pull/7735
This doesn't totally remove the gradle release plugin. It's purpose is to
remove SNAPSHOT from the version, make a tagged commit, then re-add SNAPSHOT to
the version. This should remove any interaction between the plugin and GitHub.
The release manager can push if/when the RC actually builds, as opposed to
constantly building, pushing, reverting, pushing, etc. It is fragile and also
not useful.
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
</br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)
| --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 194732)
Time Spent: 10m
Remaining Estimate: 0h
> build_release_candidate.sh should not push to github
> ----------------------------------------------------
>
> Key: BEAM-6595
> URL: https://issues.apache.org/jira/browse/BEAM-6595
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, the build_release_candidate.sh does many things beyond the build
> - Edits files in place to update the version from SNAPSHOT to non-SNAPSHOT
> - Makes a local commit
> - Pushes commits to release branch
> - Reverts on failure, pushes those to release branch
> Instead, the release manager should determine what gets pushed. It is less
> fragile of a process and avoids cruft getting pushed and churning the branch.
> The only thing the plugin is really good for is flipping SNAPSHOT away and
> back. And it isn't even that great because that's Java only and other
> languages are at non-SNAPSHOT anyhow.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
