[
https://issues.apache.org/jira/browse/BEAM-10961?focusedWorklogId=539821&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-539821
]
ASF GitHub Bot logged work on BEAM-10961:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jan/21 06:21
Start Date: 22/Jan/21 06:21
Worklog Time Spent: 10m
Work Description: sonam-vend commented on a change in pull request #13666:
URL: https://github.com/apache/beam/pull/13666#discussion_r561856612
##########
File path: runners/portability/java/build.gradle
##########
@@ -32,12 +32,19 @@ configurations {
dependencies {
compile library.java.vendored_guava_26_0_jre
- compile library.java.hamcrest_library
compile project(":runners:java-fn-execution")
compile project(":runners:java-job-service")
compile project(path: ":sdks:java:harness", configuration: "shadow")
compile library.java.vendored_grpc_1_26_0
compile library.java.slf4j_api
+ compile library.java.joda_time
+ compile "org.hamcrest:hamcrest:2.1"
+ compile project(path: ":model:fn-execution", configuration: "shadow")
+ compile project(path: ":model:job-management:", configuration: "shadow")
+ compile project(path: ":model:pipeline", configuration: "shadow")
+ compile project(":runners:core-construction-java")
+ permitUsedUndeclared project(":sdks:java:core")
Review comment:
I too wonder on this error as I used to get error differently before. Is
there anything related to this that has being updated/integrated recently?
##########
File path: runners/portability/java/build.gradle
##########
@@ -32,12 +32,19 @@ configurations {
dependencies {
compile library.java.vendored_guava_26_0_jre
- compile library.java.hamcrest_library
compile project(":runners:java-fn-execution")
compile project(":runners:java-job-service")
compile project(path: ":sdks:java:harness", configuration: "shadow")
compile library.java.vendored_grpc_1_26_0
compile library.java.slf4j_api
+ compile library.java.joda_time
+ compile "org.hamcrest:hamcrest:2.1"
+ compile project(path: ":model:fn-execution", configuration: "shadow")
+ compile project(path: ":model:job-management:", configuration: "shadow")
+ compile project(path: ":model:pipeline", configuration: "shadow")
+ compile project(":runners:core-construction-java")
+ permitUsedUndeclared project(":sdks:java:core")
Review comment:
I too wonder on this error as I used to get error differently before. Is
there anything related to this that has been updated/integrated recently?
##########
File path: runners/portability/java/build.gradle
##########
@@ -32,12 +32,19 @@ configurations {
dependencies {
compile library.java.vendored_guava_26_0_jre
- compile library.java.hamcrest_library
compile project(":runners:java-fn-execution")
compile project(":runners:java-job-service")
compile project(path: ":sdks:java:harness", configuration: "shadow")
compile library.java.vendored_grpc_1_26_0
compile library.java.slf4j_api
+ compile library.java.joda_time
+ compile "org.hamcrest:hamcrest:2.1"
+ compile project(path: ":model:fn-execution", configuration: "shadow")
+ compile project(path: ":model:job-management:", configuration: "shadow")
+ compile project(path: ":model:pipeline", configuration: "shadow")
+ compile project(":runners:core-construction-java")
+ permitUsedUndeclared project(":sdks:java:core")
Review comment:
Since, I have rebased with master, i have been getting:
```
No signature of method:
ca.cutterslade.gradle.analyze.AnalyzeDependenciesTask$_action_closure3$_closure8.doCall()
is applicable for argument types:
(org.gradle.api.internal.artifacts.PreResolvedResolvableArtifact) values:
[beam-sdks-java-core.jar (project :sdks:java:core)]
Possible solutions: findAll(), findAll(), isCase(java.lang.Object),
isCase(java.lang.Object)
```
Else it works fine as before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 539821)
Time Spent: 74h 50m (was: 74h 40m)
> Enable strict dependency analysis on all Java modules
> ------------------------------------------------------
>
> Key: BEAM-10961
> URL: https://issues.apache.org/jira/browse/BEAM-10961
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Shehzaad Nakhoda
> Assignee: Shehzaad Nakhoda
> Priority: P2
> Time Spent: 74h 50m
> Remaining Estimate: 0h
>
> This is an IWYU analysis. If the module is using its transitive deps without
> depending on them, or if it has direct dependencies it doesn't use, the build
> fails. The work involves adding dependencies or adding exclusion rules
> (example:
> https://github.com/wfhartford/gradle-dependency-analyze#configurations). Even
> if they just add exclusions across the board, it will be a big win because it
> will prevent new violations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
