[
https://issues.apache.org/jira/browse/BEAM-10961?focusedWorklogId=539897&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-539897
]
ASF GitHub Bot logged work on BEAM-10961:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jan/21 06:33
Start Date: 22/Jan/21 06:33
Worklog Time Spent: 10m
Work Description: ibzib commented on a change in pull request #13685:
URL: https://github.com/apache/beam/pull/13685#discussion_r561236446
##########
File path: sdks/java/core/build.gradle
##########
@@ -81,14 +83,15 @@ dependencies {
compile library.java.commons_compress
compile library.java.commons_lang3
shadow library.java.jsr305
+ shadow library.java.error_prone_annotations
shadow library.java.jackson_core
shadow library.java.jackson_annotations
shadow library.java.jackson_databind
shadow library.java.slf4j_api
shadow library.java.avro
shadow library.java.snappy_java
shadow library.java.joda_time
- shadow "org.tukaani:xz:1.8"
+ permitUnusedDeclared "org.tukaani:xz:1.8"
Review comment:
`permitUnusedDeclared` doesn't make sense if `xz` isn't being declared
anymore.
##########
File path: sdks/java/core/build.gradle
##########
@@ -71,6 +72,7 @@ test {
dependencies {
antlr library.java.antlr
+ permitUnusedDeclared "org.antlr:antlr4:4.7"
Review comment:
permitUnusedDeclared is okay here, but we should add a comment
explaining why.
```suggestion
// antlr is used to generate code from sdks/java/core/src/main/antlr/
permitUnusedDeclared library.java.antlr
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 539897)
Time Spent: 76h 10m (was: 76h)
> Enable strict dependency analysis on all Java modules
> ------------------------------------------------------
>
> Key: BEAM-10961
> URL: https://issues.apache.org/jira/browse/BEAM-10961
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Shehzaad Nakhoda
> Assignee: Shehzaad Nakhoda
> Priority: P2
> Time Spent: 76h 10m
> Remaining Estimate: 0h
>
> This is an IWYU analysis. If the module is using its transitive deps without
> depending on them, or if it has direct dependencies it doesn't use, the build
> fails. The work involves adding dependencies or adding exclusion rules
> (example:
> https://github.com/wfhartford/gradle-dependency-analyze#configurations). Even
> if they just add exclusions across the board, it will be a big win because it
> will prevent new violations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
