[
https://issues.apache.org/jira/browse/BEAM-6488?focusedWorklogId=195015&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-195015
]
ASF GitHub Bot logged work on BEAM-6488:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Feb/19 10:31
Start Date: 06/Feb/19 10:31
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #7709: [BEAM-6488]
Portable Flink runner support for running cross-language …
URL: https://github.com/apache/beam/pull/7709#discussion_r254199752
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/DefaultJobBundleFactory.java
##########
@@ -74,17 +74,8 @@
private final IdGenerator stageIdGenerator;
private final LoadingCache<Environment, WrappedSdkHarnessClient>
environmentCache;
- // Using environment as the initialization marker.
- private Environment environment;
private ExecutorService executor;
- private GrpcFnServer<FnApiControlClientPoolService> controlServer;
- private GrpcFnServer<GrpcLoggingService> loggingServer;
- private GrpcFnServer<ArtifactRetrievalService> retrievalServer;
- private GrpcFnServer<StaticGrpcProvisionService> provisioningServer;
- private GrpcFnServer<GrpcDataService> dataServer;
- private GrpcFnServer<GrpcStateService> stateServer;
- private MapControlClientPool clientPool;
- private EnvironmentFactory environmentFactory;
+ private String environmentURN;
Review comment:
You're still using this as an initialization marker. I suggest to re-add the
comment.
```suggestion
// Using environment as the initialization marker.
private String environmentURN;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 195015)
Time Spent: 1h 40m (was: 1.5h)
> Portable Flink runner support for running cross-language transforms
> -------------------------------------------------------------------
>
> Key: BEAM-6488
> URL: https://issues.apache.org/jira/browse/BEAM-6488
> Project: Beam
> Issue Type: New Feature
> Components: beam-model, runner-core, runner-flink, sdk-java-core,
> sdk-py-core
> Reporter: Chamikara Jayalath
> Assignee: Heejong Lee
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> To support running cross-language transforms, Portable Flink runner needs to
> support executing pipelines with steps defined to be executed for different
> environments.
> I believe this support is already there. If that is the case we should
> validate that and add any missing tests.
> If there are missing pieces, we should figure out details and create more
> JIRAs as needed.
> CC: [~angoenka]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
