[
https://issues.apache.org/jira/browse/BEAM-6488?focusedWorklogId=195562&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-195562
]
ASF GitHub Bot logged work on BEAM-6488:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Feb/19 10:13
Start Date: 07/Feb/19 10:13
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #7709: [BEAM-6488]
Portable Flink runner support for running cross-language …
URL: https://github.com/apache/beam/pull/7709#discussion_r254617824
##########
File path:
runners/java-fn-execution/src/test/java/org/apache/beam/runners/fnexecution/control/DefaultJobBundleFactoryTest.java
##########
@@ -164,7 +164,7 @@ public void createsMultipleEnvironmentOfSingleType()
throws Exception {
verify(envFactoryA, Mockito.times(0)).createEnvironment(environmentAA);
bundleFactory.forStage(getExecutableStage(environmentAA));
- verify(environmentProviderFactoryA, Mockito.times(1))
+ verify(environmentProviderFactoryA, Mockito.times(2))
Review comment:
I saw you changed the code to allow different environment types, e.g. Docker
and Process-based environment at the same time. I don't think this is necessary
because it is sufficient to have a single EnvironmentFactory (i.e. Docker) to
run cross-language pipelines.
However, I don't see why we would restrict to only one environment type. So
fine with me!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 195562)
Time Spent: 2.5h (was: 2h 20m)
> Portable Flink runner support for running cross-language transforms
> -------------------------------------------------------------------
>
> Key: BEAM-6488
> URL: https://issues.apache.org/jira/browse/BEAM-6488
> Project: Beam
> Issue Type: New Feature
> Components: beam-model, runner-core, runner-flink, sdk-java-core,
> sdk-py-core
> Reporter: Chamikara Jayalath
> Assignee: Heejong Lee
> Priority: Major
> Labels: triaged
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> To support running cross-language transforms, Portable Flink runner needs to
> support executing pipelines with steps defined to be executed for different
> environments.
> I believe this support is already there. If that is the case we should
> validate that and add any missing tests.
> If there are missing pieces, we should figure out details and create more
> JIRAs as needed.
> CC: [~angoenka]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
