[
https://issues.apache.org/jira/browse/BEAM-6426?focusedWorklogId=195231&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-195231
]
ASF GitHub Bot logged work on BEAM-6426:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Feb/19 17:00
Start Date: 06/Feb/19 17:00
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #7701: [BEAM-6426]
Fix regexp to enforce ban of non-vendored Guava
URL: https://github.com/apache/beam/pull/7701#discussion_r254360334
##########
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/stateful/StateSpecFunctions.java
##########
@@ -82,7 +82,7 @@
* StateSpec#function(scala.Function3)} signature which employs scala's
native {@link
* scala.Option}, instead of the {@link
* StateSpec#function(org.apache.spark.api.java.function.Function3)}
signature, which employs
- * Guava's {@link com.google.common.base.Optional}.
+ * Guava's {@link
org.apache.beam.vendor.guava.v20_0.com.google.common.base.Optional}.
Review comment:
Yes, this is the reason why I did not use the Import filter but the full
regular expression matcher, so people cannot hack the system this way (even for
the documentation). Of course In this particular case we can move that to an
import to make it more readable, I will do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 195231)
Time Spent: 2h 20m (was: 2h 10m)
> Enforce ban of non-vendored Guava, with exceptions
> --------------------------------------------------
>
> Key: BEAM-6426
> URL: https://issues.apache.org/jira/browse/BEAM-6426
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Kenneth Knowles
> Assignee: Ismaël Mejía
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
