[
https://issues.apache.org/jira/browse/BEAM-6426?focusedWorklogId=195243&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-195243
]
ASF GitHub Bot logged work on BEAM-6426:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Feb/19 17:11
Start Date: 06/Feb/19 17:11
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #7701: [BEAM-6426]
Fix regexp to enforce ban of non-vendored Guava
URL: https://github.com/apache/beam/pull/7701#discussion_r254358871
##########
File path: sdks/java/build-tools/src/main/resources/beam/suppressions.xml
##########
@@ -96,4 +96,10 @@
<!-- Guava use exceptions -->
<!-- Cassandra driver exposes guava in its API so we need to suppress the
error for this case. -->
Review comment:
Maybe better to change the comment or put a more generic one, WDYT ?
`Non-vendored guava imports are allowed for files that depend on libraries
that expose guava in its public API`. Good catch, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 195243)
Time Spent: 3h (was: 2h 50m)
> Enforce ban of non-vendored Guava, with exceptions
> --------------------------------------------------
>
> Key: BEAM-6426
> URL: https://issues.apache.org/jira/browse/BEAM-6426
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Kenneth Knowles
> Assignee: Ismaël Mejía
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
