[
https://issues.apache.org/jira/browse/BEAM-6548?focusedWorklogId=195608&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-195608
]
ASF GitHub Bot logged work on BEAM-6548:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Feb/19 11:14
Start Date: 07/Feb/19 11:14
Worklog Time Spent: 10m
Work Description: lgajowy commented on pull request #7670: [BEAM-6548]
Suggest mentioning users at the top of PULL_REQUEST template
URL: https://github.com/apache/beam/pull/7670#discussion_r254639118
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -2,13 +2,13 @@
------------------------
+Hello! Thanks for your contribution! Please mention someone in a comment
(`@username`) to speed up the reviewing process. See [Project
Committee](https://projects.apache.org/committee.html?beam) page, or simply tag
a suggested reviewer if you don't have anyone on your mind.
+
Review comment:
> I think the point of this blurb is not (necessarily) to tell an author how
to find a reviewer, but to make them aware that finding a reviewer is a good
next step.
Fair point. Given that Beam Contribution Guite will be linked and shows the
ways of finding the reviewer I think it's enough.
> Should this be part of the checklist?
It should be, I guess. But it should be on the top of it to draw atention
the most.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 195608)
Time Spent: 2h 10m (was: 2h)
> Improve PULL_REQUEST.md template's (user mentions suggestion)
> -------------------------------------------------------------
>
> Key: BEAM-6548
> URL: https://issues.apache.org/jira/browse/BEAM-6548
> Project: Beam
> Issue Type: Improvement
> Components: build-system
> Reporter: Lukasz Gajowy
> Assignee: Luke Cwik
> Priority: Minor
> Labels: triaged
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> It seems that sentence regarding mentioning reviewers is being easily missed.
> I suggest improving it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
