[
https://issues.apache.org/jira/browse/BEAM-10671?focusedWorklogId=553290&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-553290
]
ASF GitHub Bot logged work on BEAM-10671:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Feb/21 01:03
Start Date: 17/Feb/21 01:03
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#13908:
URL: https://github.com/apache/beam/pull/13908#discussion_r577247819
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/options/PortablePipelineOptions.java
##########
@@ -103,4 +103,32 @@
String getOutputExecutablePath();
void setOutputExecutablePath(String outputExecutablePath);
+
+ @Description(
+ "Options for configuring the environment of portable workers. Recognized
options depend on the value of defaultEnvironmentType:\n"
+ + "DOCKER: docker_container_image (optional)\n"
+ + "EXTERNAL: external_service_address (required)\n"
Review comment:
Please mention the format these options should be specified with an
example.
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/options/PortablePipelineOptions.java
##########
@@ -103,4 +103,32 @@
String getOutputExecutablePath();
void setOutputExecutablePath(String outputExecutablePath);
+
+ @Description(
+ "Options for configuring the environment of portable workers. Recognized
options depend on the value of defaultEnvironmentType:\n"
Review comment:
Mention that this will be used to configure default environment of the
pipeline SDK but not the external SDKs of any cross-language pipelines used by
the pipeline.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 553290)
Time Spent: 11h 50m (was: 11h 40m)
> Add environment configuration fields as first-class pipeline options
> --------------------------------------------------------------------
>
> Key: BEAM-10671
> URL: https://issues.apache.org/jira/browse/BEAM-10671
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-harness
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: P2
> Time Spent: 11h 50m
> Remaining Estimate: 0h
>
> The pipeline option --environment_config has completely different usages
> depending on the value of --environment_type. This is confusing for the user
> and hard to check. Additionally, --environment_config is a JSON blob for
> --environment_type=PROCESS. This JSON blob is a pain to escape and pass
> around compared to a collection of flat strings.
> We should replace --environment_config with first-class / top-level pipeline
> options for each environment type:
> DOCKER
> --environment_container_image
> PROCESS
> --environment_os
> --environment_architecture
> --environment_variables
> EXTERNAL
> --environment_service_address
> LOOPBACK
> (none)
> This way we can validate that the user is configuring these options correctly
> (ie give a warning or error if they use options that do not apply to their
> chosen --environment_type).
> We can deprecate the --environment_config option, logging a warning until
> removing this option altogether in a future Beam release.
> [https://beam.apache.org/documentation/runtime/sdk-harness-config/]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
